Skip to content

[ML] Warn for model load failures if they have a status code <500 #113280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2024
Merged

[ML] Warn for model load failures if they have a status code <500 #113280

merged 3 commits into from
Sep 23, 2024

Conversation

@maxhniebergall
Copy link
Contributor

This should prevent logging error messages when they are caused by a bad request

davidkyle
davidkyle approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Sep 20, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @maxhniebergall, I've created a changelog YAML for you.

@maxhniebergall maxhniebergall merged commit 7b52356 into main Sep 23, 2024
16 checks passed
@maxhniebergall maxhniebergall deleted the modelLoadFailureWarn branch September 23, 2024 13:03
@maxhniebergall maxhniebergall mentioned this pull request Sep 23, 2024
Merged
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
✅ 8.x
❌ 8.15 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 113280

elasticsearchmachine pushed a commit that referenced this pull request Sep 23, 2024
@maxhniebergall
[ML] Warn for model load failures if they have a status code <500 (#1…
6664c56 
…13280) (#113381)

* On model load failure, warn if the failure status code was less tahn 500

* Update docs/changelog/113280.yaml
@maxhniebergall maxhniebergall restored the modelLoadFailureWarn branch September 23, 2024 17:00
@maxhniebergall maxhniebergall deleted the modelLoadFailureWarn branch September 23, 2024 17:00
@maxhniebergall maxhniebergall mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidkyle davidkyle davidkyle approved these changes

Assignees

No one assigned

Labels

backport pending >bug :ml Machine learning Team:ML Meta label for the ML team v8.15.3 v8.16.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxhniebergall @elasticsearchmachine @davidkyle